Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incomplete get handling via HTTP compat bump and don't write failed retry streams to parent buffer in _http_request #516

Merged
merged 23 commits into from
Nov 25, 2021
Merged

Fix incomplete get handling via HTTP compat bump and don't write failed retry streams to parent buffer in _http_request #516

merged 23 commits into from
Nov 25, 2021

Commits on Nov 17, 2021

  1. don't write failed stream to parent buffer

    @IanButterworth
    IanButterworth committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    6cbdf9e View commit details
    Browse the repository at this point in the history

  2. bump HTTP compat to 0.9.17

    @IanButterworth
    IanButterworth committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    ff2cf7c View commit details
    Browse the repository at this point in the history

  3. only don't write if EOFError

    @IanButterworth
    IanButterworth committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    e92bd7e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. add incomplete stream test

    @IanButterworth
    IanButterworth committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    8ee267b View commit details
    Browse the repository at this point in the history

  2. fix by using global

    @IanButterworth
    IanButterworth committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    267aca7 View commit details
    Browse the repository at this point in the history

  3. adjust attempt num tracking

    @IanButterworth
    IanButterworth committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    63edcf6 View commit details
    Browse the repository at this point in the history

  4. account for HTTP wrapping EOFError in a HTTP.IOError

    @IanButterworth
    IanButterworth committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    ef70586 View commit details
    Browse the repository at this point in the history

  5. fix test

    @IanButterworth
    IanButterworth committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    934e511 View commit details
    Browse the repository at this point in the history

  6. minor formatting/dead code in test

    @IanButterworth
    IanButterworth authored Nov 18, 2021
    Configuration menu
    Copy the full SHA
    8d31604 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. add DownloadsBackend test

    @IanButterworth
    IanButterworth committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    4d2d871 View commit details
    Browse the repository at this point in the history

  2. DownloadsBackend: rewind output to starting position to undo incomple… 

    …te attempts
    @IanButterworth
    IanButterworth committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    f86a222 View commit details
    Browse the repository at this point in the history

  3. generalize buffer reset

    @IanButterworth
    IanButterworth committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    5f3e25c View commit details
    Browse the repository at this point in the history

  4. Revert "generalize buffer reset" 

    This reverts commit 5f3e25c.
    @IanButterworth
    IanButterworth committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    040aee3 View commit details
    Browse the repository at this point in the history

  5. Revert "DownloadsBackend: rewind output to starting position to undo … 

    …incomplete attempts"

This reverts commit f86a222.
    @IanButterworth
    IanButterworth committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    b864923 View commit details
    Browse the repository at this point in the history

  6. DownloadsBackend: use sacrificial buffer

    @IanButterworth
    IanButterworth committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    74e91ac View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. formatting and comment errors

    @IanButterworth
    IanButterworth committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c8ad389 View commit details
    Browse the repository at this point in the history

  2. make catch more specific

    @IanButterworth
    IanButterworth committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    637a532 View commit details
    Browse the repository at this point in the history

  3. add tests for total failures

    @IanButterworth
    IanButterworth committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    270925c View commit details
    Browse the repository at this point in the history

  4. always write to buffer on last attempt

    @IanButterworth
    IanButterworth committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    929d1c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. review suggestions 

    Co-Authored-By: Curtis Vogt <[email protected]>
    @IanButterworth @omus
    IanButterworth and omus committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    8dec8bb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ib/fix_retry_stream

    @IanButterworth
    IanButterworth authored Nov 24, 2021
    Configuration menu
    Copy the full SHA
    1b6f71d View commit details
    Browse the repository at this point in the history

  3. fix kwarg format for older julia versions

    @IanButterworth
    IanButterworth committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    34ae376 View commit details
    Browse the repository at this point in the history

  4. Rename attempts to max_attempts

    @omus
    omus authored Nov 24, 2021
    Configuration menu
    Copy the full SHA
    54e974c View commit details
    Browse the repository at this point in the history