Make the number of retries configurable #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I think likely there are a few more throttling error codes we could add in, in a future PR: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html#standard-retry-mode |
|
bors try |
tryBuild succeeded: |
|
AWS has a conventional env variable btw: #551 |
arnaudh
reviewed
Dec 19, 2022
| @@ -190,7 +191,7 @@ function submit_request(aws::AbstractAWSConfig, request::Request; return_headers | |||
| return false | |||
| end | |||
|
|
|||
| delays = AWSExponentialBackoff(; max_attempts=3) | |||
| delays = AWSExponentialBackoff(; max_attempts=max_attempts(aws)) | |||
There was a problem hiding this comment.
How about making the whole delay strategy configurable?
Suggested change
| delays = AWSExponentialBackoff(; max_attempts=max_attempts(aws)) | |
| delays = delays(aws) |
to give more control, e.g. tweak the initial delay or delay between retries.
Perhaps this would require exporting AWSExponentialBackoff so it's easy for users to tweak only the max attempt.
|
bors try |
tryBuild succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
max_attemptskwarg+field to AWSConfig, and amax_attemptsaccessor forAbstractAWSConfig(defaulting to 3, which is the default elsewhere in the code).I saw most of the tests are done with S3, and I also saw that the S3 throttling error (
SlowDown) was not included. I added that error code and then added a test that uses it and tests throttling retries.