Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping CI failure Slack notification job #288

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Dropping CI failure Slack notification job #288

merged 2 commits into from
Jun 16, 2023

Conversation

omus
Copy link
Member

@omus omus commented Jun 8, 2023 •
edited
Loading

Sibling PR: JuliaCloud/AWS.jl#632

Post-merge action items:

  • Delete SLACK_BOT_TOKEN from repo secrets

@omus omus requested a review from mattBrzezinski June 8, 2023 14:57
@omus omus mentioned this pull request Jun 8, 2023
Merged
1 task
@omus omus self-assigned this Jun 8, 2023
@omus
Copy link
Member Author

omus commented Jun 8, 2023

bors try

bors bot added a commit that referenced this pull request Jun 8, 2023
@bors
Try #288:
242468f
@bors
Copy link
Contributor

bors bot commented Jun 8, 2023

try

Build failed:

@omus
Copy link
Member Author

omus commented Jun 8, 2023

Blocked on #287

@omus
Copy link
Member Author

omus commented Jun 16, 2023

bors try

@omus
Copy link
Member Author

omus commented Jun 16, 2023

bors try

@bors
Copy link
Contributor

bors bot commented Jun 16, 2023

try

Already running a review

@omus
Copy link
Member Author

omus commented Jun 16, 2023

bors try-

@omus
Copy link
Member Author

omus commented Jun 16, 2023

bors try

@omus
Copy link
Member Author

omus commented Jun 16, 2023

My PR has been cursed. I'm not too worried about the workflow here so I'm going to bravely forge ahead.

@omus omus merged commit 77cd658 into master Jun 16, 2023
@omus omus deleted the cv/drop-slack-notification branch June 16, 2023 15:19
bors bot added a commit that referenced this pull request Jun 16, 2023
@bors
Try #288:
13cb2d4
@bors
Copy link
Contributor

bors bot commented Jun 16, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattBrzezinski mattBrzezinski mattBrzezinski approved these changes

Assignees

@omus omus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omus @mattBrzezinski