Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tags to assume OIDC role AWSS3.jl #291

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

omus
Copy link
Member

@omus omus commented Jun 12, 2023

Follow up to #284. When the CI is triggered from a tag the job would be unable to assume the AWSS3.jl role due to a missing trust policy. This was noticed on the v0.10.4 tag and originally thought to be from the PR #287 (comment)

@omus omus self-assigned this Jun 12, 2023
@omus
Copy link
Member Author

omus commented Jun 12, 2023

bors try

bors bot added a commit that referenced this pull request Jun 12, 2023
@bors
Copy link
Contributor

bors bot commented Jun 12, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@omus omus merged commit 938492d into master Jun 12, 2023
@omus omus deleted the cv/oidc-trust-from-tags branch June 12, 2023 15:27
@omus
Copy link
Member Author

omus commented Jun 12, 2023

Confirmation the trust tag policy is working: https://github.com/JuliaCloud/AWSS3.jl/actions/runs/5225366933/jobs/9473088872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant