Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KeySet instead of KeyIterator #349

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

martinholters
Copy link
Contributor

...in argument types of in and next on newer Julia versions.

Admittedly, I don't know whether the KeySet interface promises anything that DataStructures currently doesn't hold, but at least this makes DataStructures load again on Julia 0.7.

...in argument types of `in` and `next` on newer Julia versions.
@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #349 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files          31       31           
  Lines        2286     2286           
=======================================
  Hits         2205     2205           
  Misses         81       81
Impacted Files Coverage Δ
src/default_dict.jl 97.22% <100%> (ø) ⬆️
src/ordered_dict.jl 86.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e6001...79924e5. Read the comment docs.

@oxinabox
Copy link
Member

oxinabox commented Dec 6, 2017

LGTM,
what about SortedDict ?

@StephenVavasis
Copy link
Contributor

I haven't understood what this thread is about. What is the issue or problem for SortedDict?

@oxinabox
Copy link
Member

oxinabox commented Dec 6, 2017

It is not a problem for SortedDict (but I thought it might be).
Base has changed the name of KeyIterator to KeySet.
So if keys(::StortedDict) was returning a KeyIterator then it would need to be updated

But actually I see that keys(::SortedDict) returns its own type:
DataStructures.SDMKeyIteration
so I guess it does not need to be changed.

So I think this can be merged now

@oxinabox oxinabox merged commit 8aa166e into JuliaCollections:master Dec 6, 2017
@martinholters martinholters deleted the keyset branch December 6, 2017 07:08
@martinholters
Copy link
Contributor Author

Worth tagging a new release to have a version working on current Julia master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants