Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport allowing - in dataset names to 0.2 #49

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Backport allowing - in dataset names to 0.2 #49

merged 2 commits into from
Nov 1, 2022

Conversation

mortenpi
Copy link
Member

This backports a part of #40 that enables hyphens in dataset names to the 0.2 branch, for tagging as 0.2.7.

I created a new release-0.2 tag for to track for the 0.2 branch of the code. I think ideally that should also be added a protected branch.

Also, there is precedent in expanding allowed dataset names in minor versions, with the / introduced in 0.2.4: 0a95d21

mortenpi and others added 2 commits November 1, 2022 09:34
@mortenpi
Fix nightly tests (#50)
a385242 
* Use Pkg.develop instead of LOAD_PATH

* Expand CI test matrix to include 1.5, 1.7

1.5 is the lowest version we support here.

(cherry picked from commit ad3c9a9)
@mortenpi
Backport allowing - in dataset names to 0.2
b711cb0 
This backports a part of #40 that enables hyphens in dataset names to
the 0.2 branch, for tagging as 0.2.7.
@mortenpi mortenpi merged commit 09efe3d into release-0.2 Nov 1, 2022
@mortenpi mortenpi deleted the mp/0.2.7 branch November 1, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfitzseb pfitzseb pfitzseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortenpi @pfitzseb