Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOBuffer(@view buffer[1:n]) causes warning #696

Closed
xiaodaigh opened this issue Jul 28, 2020 · 0 comments · Fixed by #698
Closed

IOBuffer(@view buffer[1:n]) causes warning #696

xiaodaigh opened this issue Jul 28, 2020 · 0 comments · Fixed by #698

Comments

@xiaodaigh
Copy link
Contributor 

using CSV, DataFrames

x = rand(UInt8, 10)

a = CSV.read(IOBuffer(@view x[1:3]), DataFrame)

This causes an error on v0.7.5
quinnj added a commit that referenced this issue Jul 28, 2020
@quinnj
Fix IOBuffer check
c547eed 
Fixes #696. Turns out the exact `IOBuffer` definition requires a
`Vector{UInt8}`, so our check was failing.
@quinnj quinnj mentioned this issue Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IOBuffer check JuliaData/CSV.jl
1 participant
@xiaodaigh