Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #1026

Merged
merged 2 commits into from
Sep 16, 2022
Merged

fix typos #1026

merged 2 commits into from
Sep 16, 2022

Conversation

musvaage
Copy link
Contributor

README.md
docs/src/examples.md
docs/src/index.md
src/README.md
src/detection.jl
src/rows.jl
src/utils.jl
test/testfiles.jl
test/testfiles/transposed_emtpy.csv -> test/testfiles/transposed_empty.csv

$ grep latest CSV.jl/test/testfiles.jl
    ("latest (1).csv", (header=0, missingstring="\\N", pool=true),
$ ls CSV.jl/test/testfiles/latest*
CSV.jl/test/testfiles/latest\ (1).csv
$ 

Absent a clarification for the unusual file naming, a developer might implement the following as an additional commit.

$ mv 'CSV.jl/test/testfiles/latest (1).csv' CSV.jl/test/testfiles/latest.csv
$ sed -i "s/latest (1)/latest/g" CSV.jl/test/testfiles.jl
$ 

@musvaage musvaage mentioned this pull request Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 87.86% // Head: 87.91% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (bdc2f4f) compared to base (b87a0c7).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head bdc2f4f differs from pull request most recent head 0b78fd1. Consider uploading reports for the commit 0b78fd1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   87.86%   87.91%   +0.04%     
==========================================
  Files           9        9              
  Lines        2250     2250              
==========================================
+ Hits         1977     1978       +1     
+ Misses        273      272       -1     
Impacted Files Coverage Δ
src/detection.jl 88.09% <ø> (ø)
src/rows.jl 84.29% <ø> (ø)
src/utils.jl 85.16% <100.00%> (ø)
src/file.jl 94.43% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nickrobinson251
Copy link
Collaborator

thanks

@nickrobinson251 nickrobinson251 merged commit b4360cc into JuliaData:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants