Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't abuse some Parsers APIs as much #1038

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Don't abuse some Parsers APIs as much #1038

merged 3 commits into from
Oct 20, 2022

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Oct 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 87.32% // Head: 89.57% // Increases project coverage by +2.24% 🎉

Coverage data is based on head (8c69ecd) compared to base (77578cc).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   87.32%   89.57%   +2.24%     
==========================================
  Files          10        9       -1     
  Lines        2273     2244      -29     
==========================================
+ Hits         1985     2010      +25     
+ Misses        288      234      -54     
Impacted Files Coverage Δ
src/write.jl 85.19% <50.00%> (-0.32%) ⬇️
src/context.jl 88.47% <100.00%> (+3.73%) ⬆️
src/detection.jl 95.00% <100.00%> (+7.61%) ⬆️
src/CSV.jl 57.14% <0.00%> (-17.86%) ⬇️
src/workload.jl
src/rows.jl 84.65% <0.00%> (+0.36%) ⬆️
src/utils.jl 85.20% <0.00%> (+0.65%) ⬆️
src/file.jl 94.43% <0.00%> (+1.06%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quinnj quinnj merged commit 3a6f898 into main Oct 20, 2022
@quinnj quinnj deleted the jq/parsers_cleanup branch October 20, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant