Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail if writing IO doesn't support seek. Fixes #544 #545

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Dec 12, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a5a29a0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #545   +/-   ##
=========================================
  Coverage          ?   83.26%           
=========================================
  Files             ?        7           
  Lines             ?     1434           
  Branches          ?        0           
=========================================
  Hits              ?     1194           
  Misses            ?      240           
  Partials          ?        0
Impacted Files Coverage Δ
src/write.jl 87.5% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a29a0...e7956d0. Read the comment docs.

@quinnj quinnj merged commit b63e628 into master Dec 12, 2019
@quinnj quinnj deleted the jq/544 branch December 12, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant