Avoid ambiguity between user-provided UInt64 column type and PosLen #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #785 and alternative solution to #786. As opposed to the solution in that PR, which caused other issues, in this PR, we change from defining `const PosLen = UInt64` to `primitive type PosLen 64 end` and define a few helper conversions. This makes `PosLen` its own proper type, and avoids the dispatch ambiguity of the original issue.
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
==========================================
+ Coverage 91.76% 91.84% +0.07%
==========================================
Files 9 9
Lines 1798 1802 +4
==========================================
+ Hits 1650 1655 +5
+ Misses 148 147 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #785 and alternative solution to #786. As opposed to the solution
in that PR, which caused other issues, in this PR, we change from
defining
const PosLen = UInt64toprimitive type PosLen 64 endanddefine a few helper conversions. This makes
PosLenits own propertype, and avoids the dispatch ambiguity of the original issue.