Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Materialize DataFrame(Rows|Columns) as DataFrame #2058

Merged
merged 4 commits into from
Dec 20, 2019
Merged

Materialize DataFrame(Rows|Columns) as DataFrame #2058

merged 4 commits into from
Dec 20, 2019

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Dec 19, 2019

This PR reverts last two commits in #2055 so that

materializer(::Union{DataFrameRows,DataFrameColumns}) = DataFrame

Ref: #2055 (comment)

@tkf tkf mentioned this pull request Dec 19, 2019
Merged
@bkamins
Copy link
Member

bkamins commented Dec 19, 2019

@tkf - does this PR mean that #2057 should be closed? (I guess yes, but I want to be sure)

@tkf
Copy link
Contributor Author

tkf commented Dec 19, 2019

@bkamins Yes, I forgot to close it.

bkamins
bkamins reviewed Dec 20, 2019
View reviewed changes
test/tables.jl Outdated Show resolved Hide resolved
@bkamins bkamins merged commit 9ebbf6f into JuliaData:master Dec 20, 2019
@bkamins
Copy link
Member

bkamins commented Dec 20, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins left review comments

@nalimilan nalimilan nalimilan approved these changes

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkf @bkamins @nalimilan @quinnj