Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The @byrow example in the README doesn't work #164

Closed
xiaodaigh opened this issue Aug 31, 2020 · 3 comments
Closed

The @byrow example in the README doesn't work #164

xiaodaigh opened this issue Aug 31, 2020 · 3 comments

Comments

@xiaodaigh
Copy link
Contributor

using DataFrames
using DataFramesMeta
df = DataFrame(A = 1:3, B = [2, 1, 2])
df2 = @byrow df begin
    @newcol colX::Array{Float64}
    @newcol colY::Array{Union{Int,Missing}}
    :colX = :B == 2 ? pi * :A : :B
    if :A > 1
        :colY = :A * :B
    else
        :colY = Missing
    end
end
@pdeffebach
Copy link
Collaborator

Yes, we should

  1. Make a patch release with the new @byrow naming. It makes sense to do this now that @cols in @byrow works.
  2. Use actual documentation instead of a readme so that we can have separate documentation for master vs. release branch.

@bkamins
Copy link
Member

bkamins commented Aug 31, 2020

OK

@pdeffebach
Copy link
Collaborator

Closing this, it was fixed when we added real documentation in #208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants