Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host documentation on GH Actions #208

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Host documentation on GH Actions #208

merged 1 commit into from
Nov 25, 2020

Conversation

pdeffebach
Copy link
Collaborator

No description provided.

@pdeffebach
Copy link
Collaborator Author

Given that we already have a DOCUMENTER_KEY set up, I think this should work when merged into master?

I'm not sure, to be honest.

@pdeffebach
Copy link
Collaborator Author

cc @nalimilan or @quinnj, or anyone who knows how github actions work.

This PR is a bit time-sensitive, I guess since people are already asking why the docs are down.

nalimilan
nalimilan approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look reasonable. I don't know for sure, but if you merge you'll find out. :-)

@pdeffebach pdeffebach merged commit 7523fc1 into JuliaData:master Nov 25, 2020
@pdeffebach pdeffebach deleted the GH_actions_docs branch November 25, 2020 20:34
@nalimilan
Copy link
Member

Also, I was suggesting to move all CI to GitHub since Travis doesn't work at all now.

@pdeffebach
Copy link
Collaborator Author

Yes, that is definitely the next step.

@pdeffebach pdeffebach mentioned this pull request Mar 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdeffebach @nalimilan