Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport DataFrames #188

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Conversation

pdeffebach
Copy link
Collaborator

fixes #185

Less typing for me to get started also!

cc @nalimilan

@bkamins
Copy link
Member

bkamins commented Oct 7, 2020

you need to add Reexport.jl version in [compat] I think

@bkamins
Copy link
Member

bkamins commented Oct 7, 2020

OK to merge when CI finishes.

@pdeffebach pdeffebach merged commit d70420e into JuliaData:master Oct 7, 2020
@pdeffebach
Copy link
Collaborator Author

Thanks!

@pdeffebach
Copy link
Collaborator Author

All I did in this last commit is get rid of an unexported DataFramesMeta.select method which was used internally in the old macros, but not the new implementation.

@pdeffebach pdeffebach mentioned this pull request Oct 7, 2020
##
##############################################################################

select(d::AbstractDataFrame, arg) = d[!, arg]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this one was... embarrassing. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reexport DataFrames
3 participants