-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add real docs #203
Add real docs #203
Conversation
Great! Let me know when you are done and I will have a look (though @nalimilan is much better than me with documentation). |
Okay I've taken this PR as far as I'm comfortable with for now. The changes to the docs are minimal. But lots of examples have been changed to no longer rely on random number generation. Next step is hosting. If this were my own package I would fumble through the hosting configuration on my own. But given this is owned by JuliaData I would like someone, probably @quinnj or @nalimilan to help take this over the finish line. in particular, the part about adding an ssh key (which I have, I think) and making sure a website actually exists confuses me. Thank you! |
Usually it's not too bad to setup; I just follow the Documenter.jl guide for hosting; in travis, you put the DOCUMENTER_KEY as an environment variable (I can do this if you dm me the key), then make sure your travis job has a docs build job. |
I've worked through the documenter docs on hosting, and i need to add a ssh key for the repository. I don't have ownership permissions to do that for DataFramesMeta (can't click on settings at the repo page on github). I need one of you to work through this section to set up the SSH deploy keys. |
Okay I think this is ready for another review. I have
I think that if we merge this the docs should deploy correctly. Please let me know! |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Tests pass! |
docs/src/index.md
Outdated
avoids filling up the limited macro name space. The main downside is | ||
that more magic happens under the hood. | ||
|
||
This method is extensible. Here is a comparison of the macro and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comparison or an example how one could write ones own extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I want to expose this API formally yet. Its untested, and I don't know if there is a need to someone to write their own extension. I think we should cut this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - then I would cut this.
Looks good. Thank you. I have left some minor comments. |
Thanks! I deleted the example about extending Ready to merge if people approve! |
Thanks for your feedback, everyone! I am going to merge! |
This is a major PR (it felt like the last one was, too!)
I am getting us set up with "real" documentation.
README
toindex.md
api.md
with the@doc
macrosjldoctests
so they runI still need to
README
Also, I can't get the link to the
api
page to work from theindex
page. If anyone knows how to fix this, please let me know!cc @bkamins, @nalimilan