-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @byrow attempt 2 #250
Merged
Merged
Add @byrow attempt 2 #250
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
dc88ed8
add @byrow attempt 2
pdeffebach 33248f7
docstring in transform
pdeffebach 2112f4c
ready for review
pdeffebach d61df1a
small fix
pdeffebach d3e401b
remove deprecated tests
pdeffebach eab9743
better tests
pdeffebach f4be9f0
long docs
pdeffebach 61d96f4
more docs
pdeffebach 480ef54
more rewrite
pdeffebach d9662f0
fixed triple quotes
pdeffebach e0e1307
update tests for all other macros
pdeffebach e85b44c
add @with test
pdeffebach ae5a399
tests pass
pdeffebach bf6f876
respond to B 2
pdeffebach 1c426a1
Apply suggestions from code review
pdeffebach c3c6454
fixes
pdeffebach c8a4ae7
fix conflicts
pdeffebach e9d110a
new byrow test file
pdeffebach 08df117
docstrings everywhere
pdeffebach 216dbe0
fix tests
pdeffebach b75f3c2
bump documenter
pdeffebach 288f192
Apply suggestions from code review
pdeffebach ebf6189
sentence introducing byrow
pdeffebach 710b53a
a few more type annotations
pdeffebach eac79e0
Update src/macros.jl
nalimilan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
[deps] | ||
DataFramesMeta = "1313f7d8-7da2-5740-9ea0-a2ca25f37964" | ||
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" | ||
|
||
[compat] | ||
Documenter = "0.25" | ||
Documenter = "0.27" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,5 @@ | |
|
||
```@autodocs | ||
Modules = [DataFramesMeta] | ||
Private = false | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention
@byrow
at the top of the file?Rather than starting the section with technical details, it would be more user-friendly to say what
@byrow
does first, then show examples, and only then mentionByRow
and the fact that@byrow
isn't a real macro.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the second paragraph still applies: it would be nice to start with a sentence or two saying that
@byrow
allows writing code that is applied to each row instead of having to vectorize it.