Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dplyr tutorial port, clean up docs so documenter is happy #279
Add dplyr tutorial port, clean up docs so documenter is happy #279
Changes from all commits
1caa748
6cc9d9b
2dbb295
1fa1b35
a1bf264
4622dff
235d4d6
de82c82
73ef476
b8a5a00
a2aff4e
185436f
b460d28
b12d1dc
4d7da4a
7827fb0
cd11e19
73931cd
aa7423a
cb61bfb
a8b4ad6
ea8587b
2a5f6b1
1bdf600
2f0c0ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
$
required here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
Right now, the parsing for selecting columns is exactly the same as working with anonymous functions. So since
@transform df :y = :x .+ 1
would be ambiguous if we allowed1
to be a column selector in the anonymous function, we need the same thing when doingselect
.Not ideal, though. We can change this before 1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
$1
makes sense - it just probably should be well explained somewhere.