Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.9.0 release #282

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

pdeffebach
Copy link
Collaborator

This PR does 3 things

  1. exports @passmissing for users to use the documentation, ? @passmissing will work even if @passmissing ... won't outside of DataFramesMeta.jl macros
  2. Only allows for DataFrames > 1.0, to fix subset not defined #274
  3. Bump version to 0.9.0

We need to bump the version because we add new features and are pre-1.0.

@pdeffebach
Copy link
Collaborator Author

@bkamins I looked over some of the references to keyword argments in the documentation. Honestly I don't think it's that bad. @transform df :y = f(:x) is a keyword argument, for the most part. In the absence of having a better idea for a name, I think we should make a release.

@bkamins
Copy link
Member

bkamins commented Aug 12, 2021

OK. For me x = something is a keyword form, and :x = something is more of an assignment, but I am OK with leaving the keyword argument style. Maybe we could in the first place where we mention it just give an example that by :x = :y we mean that this is a keyword argument style?

@pdeffebach
Copy link
Collaborator Author

Okay after #286 let's merge this and make a release!

@bkamins
Copy link
Member

bkamins commented Aug 13, 2021

#286 is already merged :)

@pdeffebach pdeffebach merged commit dbad882 into JuliaData:master Aug 13, 2021
@pdeffebach pdeffebach deleted the fixes_0.9 branch August 13, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subset not defined
2 participants