Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclamations #294

Merged
merged 10 commits into from
Sep 8, 2021
Merged

Add exclamations #294

merged 10 commits into from
Sep 8, 2021

Conversation

pdeffebach
Copy link
Collaborator

Fixes #293

@bkamins @nalimilan please review and merge!

Tests pass. This is a major oversight and needs to be fixed quickly.

Thank you!

Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving to speed up process.
You need to bump the version and update the docs before merging (I will do this if you do not do this soon).

@bkamins
Copy link
Member

bkamins commented Sep 8, 2021

There is some issue with Documenter in CI. But when I run it locally it works.

@bkamins bkamins closed this Sep 8, 2021
@bkamins bkamins reopened this Sep 8, 2021
@pdeffebach
Copy link
Collaborator Author

If I merge and the build fails, will it use the old version of the docs?

@bkamins
Copy link
Member

bkamins commented Sep 8, 2021

I think so. Let us try to make Documenter work for a bit more 😄.

@pdeffebach pdeffebach merged commit 9b696ed into JuliaData:master Sep 8, 2021
@pdeffebach pdeffebach deleted the add_exclamations branch September 8, 2021 14:24
@pdeffebach
Copy link
Collaborator Author

Jacob's snippet worked.

Thanks for the fast turnaround! Registration here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rtransform! and @rselect! aren't actually modifying dataframe
2 participants