Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sortperm by alternative pattern #338

Merged
merged 6 commits into from
Oct 10, 2022
Merged

Replace sortperm by alternative pattern #338

merged 6 commits into from
Oct 10, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Oct 3, 2022

Fixes #337

docs/src/dplyr.md Outdated Show resolved Hide resolved
docs/src/dplyr.md Outdated Show resolved Hide resolved
@pdeffebach
Copy link
Collaborator

Can you add an example with strings so that its clear ordinalrank is what to do with strings?

@bkamins
Copy link
Member Author

bkamins commented Oct 5, 2022

I have added it to the manual (I assume you wanted this).

In general we might think about a more flexible API for @orderby allowing to pass additional parameters (like rev) directly as now it is quite cumbersome. If you want to pass by, lt etc. you essentially need to use sortperm and invperm trick as sortperm accepts all arguments.

@pdeffebach
Copy link
Collaborator

@orderby allowing to pass additional parameters (like rev) directly as now it is quite cumbersome. If you want to pass by, lt etc. you essentially need to use sortperm and invperm trick as sortperm accepts all arguments.

Ehhh this doesn't seem so bad. But I'll make an issue to keep track.

Thanks for the PR!

@pdeffebach pdeffebach merged commit b70bec4 into master Oct 10, 2022
@bkamins bkamins deleted the bkamins-patch-1 branch October 10, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems in @orderby
2 participants