Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify index.md first example #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nathanrboyer
Copy link

@nathanrboyer nathanrboyer commented Apr 18, 2024

As a generalization, the highlights of DataFramesMeta.jl I have seen across the internet take unreadable DataFrames.jl syntax and make it readable with DataFramesMeta.jl, especially using multiple chained transformations. I think a better strategy is to take readable DataFrames.jl syntax and make it simple with DataFramesMeta.jl.

I cannot appreciate what DataFramesMeta.jl is doing if I cannot parse the Base DataFrames.jl syntax well enough to understand the goal, and the longer chained examples add to the feeling that DataFramesMeta.jl is more than most need. The package authors probably think the goal will be obvious by reading the DataFramesMeta.jl code, but since there are macros involved, the syntax could mean anything.


This instance is not particularly egregious. However, the first, sum, and broadcasting .'s are not different between the two pacakge syntaxes, so why overcomplicate the example.

@nathanrboyer nathanrboyer changed the title Change index.md first example Simplify index.md first example Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant