Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a generalization, the highlights of DataFramesMeta.jl I have seen across the internet take unreadable DataFrames.jl syntax and make it readable with DataFramesMeta.jl, especially using multiple chained transformations. I think a better strategy is to take readable DataFrames.jl syntax and make it simple with DataFramesMeta.jl.
I cannot appreciate what DataFramesMeta.jl is doing if I cannot parse the Base DataFrames.jl syntax well enough to understand the goal, and the longer chained examples add to the feeling that DataFramesMeta.jl is more than most need. The package authors probably think the goal will be obvious by reading the DataFramesMeta.jl code, but since there are macros involved, the syntax could mean anything.
This instance is not particularly egregious. However, the
first
,sum
, and broadcasting.
's are not different between the two pacakge syntaxes, so why overcomplicate the example.