Export coalesce #72
Export coalesce #72
Conversation
src/Missings.jl
Outdated
| @@ -30,7 +30,7 @@ end | |||
| import Base: ==, !=, <, *, <=, !, +, -, ^, /, &, |, xor | |||
|
|
|||
| if VERSION >= v"0.7.0-DEV.2762" | |||
| using Base: ismissing, missing, Missing, MissingException | |||
| using Base: coalesce, ismissing, missing, Missing, MissingException | |||
There was a problem hiding this comment.
IIRC coalesce has been added later, when I removed Nullable, so it should be under a different version check.
|
I had a fix for this locally along w/ some other 0.7 compat. Any objections to merging? |
|
|
||
| # Deprecations | ||
| @deprecate skip(itr) skipmissing(itr) false | ||
| Compat.coalesce(x::Missing) = missing |
There was a problem hiding this comment.
This should only be defined before Base includes coalesce, or it's going to overwrite the equivalent Base method.
There was a problem hiding this comment.
That assumes that Compat already defines coalesce(x::Missing), which it currently doesn't (it's commented out). It really boils down to whether the actual compat definition is in Missings or Compat.
There was a problem hiding this comment.
Right, but I was speaking about a different issue, which is that recent Julia 0.7 versions define that method, and that Compat.coalesce = Base.coalesce there.
There was a problem hiding this comment.
I don't think so? I don't see any overwrite happening on latest master?
There was a problem hiding this comment.
Easy enough to just wrap this in is !isdefined(Base, :coalesce) regardless.
Fixes #71. Not sure why this wasn't exported before.