Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lookup for SSAValues in foreigncalls and quote the library if it is a symbol #222

Closed
wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Mar 27, 2019

Fixes #220


julia> @interpret CSV.read("../SampleCSVFile_11kb.csv")
99×10 DataFrames.DataFrame. Omitted printing of 7 columns
│ Row │ 1      │ Eldon Base for stackable storage shelf, platinum                                   │ Muhammed MacIntyre │
│     │ Int64⍰ │ Union{Missing, String}                                                             │ String⍰            │
├─────┼────────┼────────────────────────────────────────────────────────────────────────────────────┼────────────────────┤
│ 1   │ 2      │ 1.7 Cubic Foot Compact "Cube" Office Refrigerators                                 │ Barry French       │
│ 2   │ 3      │ Cardinal Slant-D\xae Ring Binder, Heavy Gauge Vinyl                                │ Barry French       │
│ 3   │ 4      │ R380                                                                               │ Clay Rozendal      │
│ 4   │ 5      │ Holmes HEPA Air Purifier                                                           │ Carlos Soltero     │
│ 5   │ 6      │ G.E. Longer-Life Indoor Recessed Floodlight Bulbs                                  │ Carlos Soltero     │
│ 6   │ 7      │ Angle-D Binders with Locking Rings, Label Holders                                  │ Carl Jackson       │
│ 7   │ 8      │ SAFCO Mobile Desk Side File, Wire Frame                                            │ Carl Jackson       │

Not sure how to test this but I'll figure something out,

@KristofferC
Copy link
Member Author

Should have run the tests locally :P

@timholy
Copy link
Member

timholy commented Mar 27, 2019

Hah, collision. See teh/fix_220. (Sorry, I thought you were focused on #206.) Do what you will, I'm incommunicado for the next couple hours.

@KristofferC
Copy link
Member Author

Heh, I was converging to your solution now.

@KristofferC KristofferC deleted the kc/ccall branch February 21, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants