More 1.12 compat #635
Merged
More 1.12 compat #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
approved these changes
Jul 9, 2024
src/interpret.jl
Outdated
Comment on lines
544
to
546
| mod, name = g.mod, g.name | ||
| else | ||
| mod, name = moduleof(frame), g::Symbol |
There was a problem hiding this comment.
Looks like now we don't need this mod variable? Assuming these GlobalRef modules are always same as moduleof(frame).
There was a problem hiding this comment.
We just just remove this block and use g directly, since we're falling back to the base interpreter anyway.
Fixes most of the semantic issues on 1.12 - there's still some test failures related to source locations, but should be usable for day-to-day things at least.
Keno
added a commit
to JuliaDebug/LoweredCodeUtils.jl
that referenced
this pull request
Jul 18, 2024
Depends on JuliaDebug/JuliaInterpreter.jl#635, so will need appropriate version bumps before release.
Keno
added a commit
to JuliaDebug/LoweredCodeUtils.jl
that referenced
this pull request
Jul 18, 2024
* More 1.12 compat Depends on JuliaDebug/JuliaInterpreter.jl#635, so will need appropriate version bumps before release. * Update src/codeedges.jl Co-authored-by: Shuhei Kadowaki <[email protected]> --------- Co-authored-by: Shuhei Kadowaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of the semantic issues on 1.12 - there's still some test failures related to source locations, but should be usable for day-to-day things at least.