Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build compiled methods to handle llvmcall #67

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Build compiled methods to handle llvmcall #67

merged 1 commit into from
Feb 26, 2019

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 26, 2019

This addresses #13 (comment) by building a compiled call that gets dispatched to.

Unfortunately, generalizing this to handle :foreigncall does not fix #28. So we'll have to do that by a different means.

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #67   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           8      8           
  Lines        1207   1256   +49     
=====================================
- Misses       1207   1256   +49
Impacted Files Coverage Δ
src/interpret.jl 0% <0%> (ø) ⬆️
src/JuliaInterpreter.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f55669...0d2f109. Read the comment docs.

@timholy timholy merged commit 8ee5829 into master Feb 26, 2019
@timholy timholy deleted the teh/llvmcall branch February 26, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MWE of char crash
2 participants