Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid illegal instruction crash by circumventing ccall #68

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 26, 2019

This circumvents #28 by "blacklisting" Base methods that have a ccall to memcpy. This won't catch packages, unfortunately, but this seems to be the best we can do.

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #68   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           8      8           
  Lines        1207   1211    +4     
=====================================
- Misses       1207   1211    +4
Impacted Files Coverage Δ
src/JuliaInterpreter.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f55669...b492ee5. Read the comment docs.

@timholy timholy merged commit 0ce67d6 into master Feb 26, 2019
@timholy timholy deleted the teh/bypass_28 branch February 26, 2019 13:44
This was referenced Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants