skip Symmetric tests, rm comments

test/rulesets/Base/mapreduce.jl

@@ -57,23 +57,16 @@
                 @test iszero(unthunk(rrule(prod, Diagonal(rand(T,3)), dims=1)[2](ones(1,3))[2]))
                 @test unthunk(rrule(prod, Diagonal(rand(T,1)))[2](1.0)[2]) == hcat(1) # 1x1 sparse matrix
                 @test unthunk(rrule(prod, Diagonal(ones(T,2)), dims=1)[2](ones(1,2))[2]) == [0 1; 1 0]
+
                 # Triangular -- almost equally stupud
                 @test iszero(unthunk(rrule(prod, UpperTriangular(rand(T,3,3)))[2](1.0)[2]))
                 @test unthunk(rrule(prod, UpperTriangular(ones(T,2,2)))[2](1.0)[2]) == [0 0; 1 0]
+
                 # Symmetric -- at least this doesn't have zeros, still an unlikely combination
                 xs = Symmetric(rand(T,4,4))
                 @test_skip test_rrule(prod, xs ⊢ rand(T,4,4))
                 @test_skip test_rrule(prod, xs ⊢ rand(T,4,4), fkwargs=(dims=2,))
-#=
-xs = Symmetric(100randn(3,3))
-Zygote.gradient(x -> sum(prod(x,dims=1)), xs)[1]
-ForwardDiff.gradient(x -> sum(prod(x,dims=1)), Matrix(xs))
-Zygote.gradient(x -> sum(prod(x,dims=1)), Matrix(xs))[1]
-# These all agree. This time test_rrule, besides an error, gives a complaint that aa ≈ bb fails, where:
-aa, bb = [19520.328243416912 -10637.452753538959 10525.400561900045; -2510.9032814879456 -3998.8778331597046 -9169.556884964955; 635.6849617151897 -2346.1691173613817 1445.40000910585], [19520.32824346742 -13148.35603493111 11161.0855235898; -13148.35603493111 -3998.877833179008 -11515.726002337731; 11161.0855235898 -11515.726002337731 1445.4000090979655]
-bb ≈ (aa .+ aa') .- Diagonal(aa)  # not quite a projection. Is that right?
-=#
-                @test unthunk(rrule(prod, Symmetric(rand(T,3,3)))[2](1.0)[2]) isa Matrix
+                @test unthunk(rrule(prod, Symmetric(ones(T,2,2)))[2](1.0)[2]) == [1 1; 1 1]
             end
         end
         @testset "Array{Float32}, no zero entries" begin