Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO sections in docs #150

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Remove TODO sections in docs #150

merged 2 commits into from
Jan 20, 2020

Conversation

oxinabox
Copy link
Member

The information is in other sections,
and even if TODO, belongs in issues, rather than in docs.

It also just looks bad

nickrobinson251
nickrobinson251 reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@nickrobinson251 nickrobinson251 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this whole page just be deleted, and the two paragraphs at the top be moved to their section of the home page? i.e. why keep this as its own page?

@oxinabox
Copy link
Member Author

yeah maybe

@mattBrzezinski
Copy link
Member

I would be in favour of moving the two lines into index.md

@oxinabox
Copy link
Member Author

I have moved the info to the FAQ

@oxinabox oxinabox merged commit f5527a5 into master Jan 20, 2020
@nickrobinson251 nickrobinson251 deleted the ox/removetodoindocs branch January 20, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrobinson251 nickrobinson251 nickrobinson251 left review comments

@mattBrzezinski mattBrzezinski mattBrzezinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxinabox @mattBrzezinski @nickrobinson251