-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update support for timing internals #608
Update support for timing internals #608
Conversation
If you allow JuliaInterpreter 0.9 then I think tests will run: Line 21 in f13e0a4
|
Thanks. Seems like CompatHelper needs fixing on this repo? |
I don't think CompatHelper deals with compat entries for test dependencies in Project.toml (not test/Project.toml)? |
Failure on x64 is not new, same as https://github.com/JuliaDiff/ChainRules.jl/runs/5705588458?check_suite_focus=true . Failure on x86 is weird. |
In case anyone is wondering about (un)locking the conversation: I pressed the wrong buttons in the Android app. Sorry for the unrelated noise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nicer if tests pass, but I think we should do this.
Can you increase the version number too?
These internals were consolidated in JuliaLang/julia#45015
Closes #609