Add opting out of rules #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
- Coverage 92.32% 92.12% -0.20%
==========================================
Files 14 14
Lines 756 775 +19
==========================================
+ Hits 698 714 +16
- Misses 58 61 +3
Continue to review full report at Codecov.
|
oxinabox
commented
Jul 19, 2021
Comment on lines
+434
to
+437
| $(esc(no_rule_target)) = nothing | ||
| $(esc(expr)) = nothing |
There was a problem hiding this comment.
I think this escaping will mean this doesn't work in anything that doesn't have ChainRulesCore imported.
It needs a test in the isolated scope testset.
But I am ok leaving that for a follow up PR.
This was referenced Jul 19, 2021
mzgubic
reviewed
Jul 20, 2021
Co-authored-by: Miha Zgubic <[email protected]>
Co-authored-by: Miha Zgubic <[email protected]>
mzgubic
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #377
This is actually very breaking so can't be merged til after we tag 1.0-DEV.
It will not break anything in practice til something uses it though.
and it won't break Diffactor.
It will break Zygote and Nabla.
Before mergjng this I want to make the corresponding changes to ChainRulesOverload generation,
and Zygote.