Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use hasproperty, not hasfield for ProjectTo #414

Merged
merged 2 commits into from
Jul 26, 2021
Merged

use hasproperty, not hasfield for ProjectTo #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d7b6d
use hasproperty, not hasfield for ProjectTo
oxinabox Jul 26, 2021
b0f2d77
Compat hasproperty
oxinabox Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRulesCore"
uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
version = "1.0.0"
version = "1.0.1"

[deps]
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
Expand Down
2 changes: 1 addition & 1 deletion src/ChainRulesCore.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ using Base.Broadcast: broadcasted, Broadcasted, broadcastable, materialize, mate
using Base.Meta
using LinearAlgebra
using SparseArrays: SparseVector, SparseMatrixCSC
using Compat: hasfield
using Compat: hasfield, hasproperty

export frule, rrule # core function
# rule configurations
Expand Down
2 changes: 1 addition & 1 deletion src/projection.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ function (project::ProjectTo{AbstractArray})(dx::AbstractArray{S,M}) where {S,M}
end
# Then deal with the elements. One projector if AbstractArray{<:Number},
# or one per element for arrays of anything else, including arrays of arrays:
dz = if hasfield(typeof(backing(project)), :element)
dz = if hasproperty(project, :element)
T = project_type(project.element)
S <: T ? dy : map(project.element, dy)
else
Expand Down