Define SpecialFunctions.gamma_inc for ForwardDiff.Dual
#587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
- Coverage 86.63% 86.49% -0.15%
==========================================
Files 9 9
Lines 898 896 -2
==========================================
- Hits 778 775 -3
- Misses 120 121 +1
Continue to review full report at Codecov.
|
|
Any idea why this one is failing on nightly? |
|
No, I'll have a look when I'm back from vacation next week. |
|
I reran the tests and it seems they pass now. Maybe some recent change in Julia nightly or SpecialFunctions fixed the test errors. |
andreasnoack
approved these changes
Aug 4, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a definition of
SpecialFunctions.gamma_inc(::Real, ::Dual, ::Integer).Similar to
logabsgamma(added in #585) this function returns a tuple and hence is not handled by DiffRules.As in the CR definitions in SpecialFunctions, only the derivatives with respect to the second argument are defined since derivatives wrt to the first argument are given in terms of (regularized) hypergeometric functions and hence would require additional dependencies (see JuliaMath/SpecialFunctions.jl#317). The third argument indicates the desired accuracy, and hence the function is not differentiable wrt to the third argument anyway.