Special Dispatch for Static Array #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -259,6 +259,11 @@ function init_jacobian(c::AbstractMaybeSparseJacobianCache) | |||
| return init_jacobian(__getfield(c, Val(:jac_prototype)), T, c.fx, c.x) | |||
| end | |||
| init_jacobian(::Nothing, ::Type{T}, fx, x) where {T} = similar(fx, T, length(fx), length(x)) | |||
| function init_jacobian(::Nothing, ::Type{T}, fx::StaticArray, x::StaticArray) where {T} | |||
| # We want to construct a MArray to preserve types | |||
| J = StaticArrays.MArray{Tuple{length(fx), length(x)}, T}(undef) | |||
There was a problem hiding this comment.
use Size so it's inferred?
There was a problem hiding this comment.
It is already compile time rn.
julia> @code_warntype init_jacobian(nothing, Float32, y, x)
MethodInstance for SparseDiffTools.init_jacobian(::Nothing, ::Type{Float32}, ::MVector{30, Float64}, ::SVector{30, Float64})
from init_jacobian(::Nothing, ::Type{T}, fx::StaticArray, x::StaticArray) where T @ SparseDiffTools /mnt/research/nlsolve/SparseDiffTools.jl/src/highlevel/common.jl:262
Static Parameters
T = Float32
Arguments
#self#::Core.Const(SparseDiffTools.init_jacobian)
_::Core.Const(nothing)
_::Core.Const(Float32)
fx::MVector{30, Float64}
x::SVector{30, Float64}
Locals
J::MMatrix{30, 30, Float32, 900}
Body::MMatrix{30, 30, Float32, 900}
1 ─ %1 = StaticArrays.MArray::Core.Const(MArray)
│ %2 = SparseDiffTools.Tuple::Core.Const(Tuple)
│ %3 = SparseDiffTools.length(fx)::Core.Const(30)
│ %4 = SparseDiffTools.length(x)::Core.Const(30)
│ %5 = Core.apply_type(%2, %3, %4)::Core.Const(Tuple{30, 30})
│ %6 = Core.apply_type(%1, %5, $(Expr(:static_parameter, 1)))::Core.Const(MArray{Tuple{30, 30}, Float32})
│ (J = (%6)(SparseDiffTools.undef))
└── return J
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
==========================================
- Coverage 87.60% 87.38% -0.22%
==========================================
Files 21 21
Lines 1226 1229 +3
==========================================
Hits 1074 1074
- Misses 152 155 +3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.