Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Kind-of) Type Stability Fixes for No Chunksize Specified #271

Merged
merged 5 commits into from
Nov 1, 2023
Merged

(Kind-of) Type Stability Fixes for No Chunksize Specified #271

merged 5 commits into from
Nov 1, 2023

Conversation

avik-pal
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9d68481) 87.34% compared to head (41033f4) 87.32%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   87.34%   87.32%   -0.03%     
==========================================
  Files          21       21              
  Lines        1241     1254      +13     
==========================================
+ Hits         1084     1095      +11     
- Misses        157      159       +2     
Files Coverage Δ
ext/SparseDiffToolsSymbolicsExt.jl 100.00% <ø> (ø)
ext/SparseDiffToolsZygoteExt.jl 97.36% <ø> (ø)
src/coloring/acyclic_coloring.jl 98.57% <ø> (ø)
src/coloring/backtracking_coloring.jl 0.00% <ø> (ø)
src/coloring/high_level.jl 100.00% <ø> (ø)
src/coloring/matrix2graph.jl 100.00% <ø> (ø)
src/differentiation/compute_hessian_ad.jl 100.00% <100.00%> (ø)
src/differentiation/compute_jacobian_ad.jl 91.80% <ø> (ø)
src/differentiation/jaches_products.jl 95.53% <ø> (ø)
src/differentiation/vecjac_products.jl 93.75% <ø> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal
Copy link
Contributor Author

The ordinarydiffeq test failure is just some internet problem most likely. the nonlinearsolve ones will be handled by SciML/NonlinearSolve.jl#265. Once the tests on that PR pass we can merge this

@avik-pal
Copy link
Contributor Author

@ChrisRackauckas this should be good to go

@ChrisRackauckas ChrisRackauckas merged commit 7d23bec into JuliaDiff:master Nov 1, 2023
14 of 18 checks passed
@avik-pal avik-pal deleted the ap/tagging branch November 1, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants