Non allocating versions for StaticArrays #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 86.23% 85.98% -0.25%
==========================================
Files 22 22
Lines 1293 1313 +20
==========================================
+ Hits 1115 1129 +14
- Misses 178 184 +6 ☔ View full report in Codecov by Sentry. |
src/highlevel/finite_diff.jl
Outdated
| @@ -10,6 +10,7 @@ __getfield(c::FiniteDiffJacobianCache, ::Val{:jac_prototype}) = c.jac_prototype | |||
|
|
|||
| function sparse_jacobian_cache(fd::Union{AutoSparseFiniteDiff, AutoFiniteDiff}, | |||
| sd::AbstractMaybeSparsityDetection, f::F, x; fx = nothing) where {F} | |||
| x = __make_mutable(x) # FiniteDiff is bad at handling immutables | |||
There was a problem hiding this comment.
how so? What is wrong with those dispatches?
There was a problem hiding this comment.
I fixed it without this. Ig the assumption there is if J is mutable, x is implicitly assumed to be mutable in FiniteDiff, which is a reasonable assumption.
|
The NonlinearSolve failures are fine here, it wasn't handling StaticArrays correctly in the first place, once the new PR is in, the failures should be patched. It is taking forever to finish because its printing like 25k lines of error 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.