Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PolyesterForwardDiff Support #281

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Add PolyesterForwardDiff Support #281

merged 2 commits into from
Jan 18, 2024

Conversation

avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Jan 16, 2024

For the colored AD we fallback to regular ForwardDiff.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4ad919a) 85.93% compared to head (9ccbe30) 83.02%.
Report is 2 commits behind head on master.

Files Patch % Lines
ext/SparseDiffToolsPolyesterForwardDiffExt.jl 53.12% 15 Missing ⚠️
src/highlevel/common.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   85.93%   83.02%   -2.91%     
==========================================
  Files          22       23       +1     
  Lines        1358     1426      +68     
==========================================
+ Hits         1167     1184      +17     
- Misses        191      242      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal
Copy link
Contributor Author

Wait for #282

@avik-pal avik-pal changed the title [WIP] Add PolyesterForwardDiff Support Add PolyesterForwardDiff Support Jan 17, 2024
@avik-pal
Copy link
Contributor Author

This is ready to be merged on my end.

@ChrisRackauckas ChrisRackauckas merged commit 3b42466 into JuliaDiff:master Jan 18, 2024
28 of 31 checks passed
@avik-pal avik-pal deleted the ap/polyester-forward-diff branch January 30, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants