Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for 0.4 and 0.5, fix type and immutable depwarns #36

Merged
merged 4 commits into from
Aug 7, 2017

Conversation

tkoolen
Copy link
Contributor

@tkoolen tkoolen commented Aug 4, 2017

Awaiting #35 decision.

BTW, I also tried to fix the current_module depwarns using @__MODULE__, but that didn't work straight away; not sure why yet.

Closes #35

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks! I assume it's ready to go?

@mortenpi
Copy link
Member

mortenpi commented Aug 7, 2017

As for current_module() -- I was looking into this a while back. The issue is that current_module() and @__MODULE__ are not equivalent, since current_module() returns the module where the function is called, but @__MODULE__ gives the module where the function is defiend. Here's a simple example of the difference:

module Foo
foo() = current_module(), @__MODULE__
end
Foo.foo()

If I remember correctly, template_hook() causes issues, since it has to figure out in which module it is being called. I didn't figure out how the get that information in 0.7 though. It needs to be fixed, but it doesn't have to happen in this PR.

@tkoolen
Copy link
Contributor Author

tkoolen commented Aug 7, 2017

Yep, ready to go as far as I'm concerned. Thanks!

@mortenpi mortenpi merged commit 85f4d46 into JuliaDocs:master Aug 7, 2017
@mortenpi
Copy link
Member

mortenpi commented Aug 7, 2017

Nightly test failures are unrelated, due to a bug on Julia master as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop 0.4 and 0.5?
2 participants