Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt documentation from "QuantumCitations" fork #4

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

goerz
Copy link
Member

@goerz goerz commented Jul 11, 2023

This makes the documentation appropriate for QuantumCitations having been merged back into DocumenterCitations.

The default style (following QuantumCitations) has changed to :numeric, making this a breaking change. The differences to the previous version of DocumenterCitations are outlined in NEWS.md, serving as a guideline for any users switching to the next release of DocumenterCitations, but wanting to keep the existing author-year style citations.

@goerz goerz added the documentation Improvements or additions to documentation label Jul 11, 2023
@goerz goerz marked this pull request as ready for review July 11, 2023 16:48
@goerz
Copy link
Member Author

goerz commented Jul 11, 2023

I've set version = "0.3.0-dev", in anticipation of this being released as v0.3.0 (breaking release). There are a few places in the documentation where I explicitly talk about "pre/post v0.3.0", to help any user who wants to switch to the new release, but keep their existing author-year citation style.

@goerz
Copy link
Member Author

goerz commented Jul 11, 2023

Please also review the README.md and NEWS.md at https://github.com/JuliaDocs/DocumenterCitations.jl/tree/mg/update-documentation.

It seems to me that merging this actually completes re-integrating QuantumCitations back into DocumenterCitations. We should be able to make a release based on this. It might be a good idea to test things out for a few days, though. For example, maybe someone (other than me) with an existing project using DocumenterCitations should try out the new master branch and see if everything works for them.

@goerz
Copy link
Member Author

goerz commented Jul 11, 2023

Good catch in #5… let me rebase this

This makes the documentation appropriate for QuantumCitations having
been merged back into DocumenterCitations.

The default style (following QuantumCitations) has changed to
`:numeric`, making this a breaking change. The differences to the
previous version of DocumenterCitations are outlined in `NEWS.md`,
serving as a guideline for any users switching to the next release of
DocumenterCitations, but wanting to keep the existing author-year style
citations.
@goerz
Copy link
Member Author

goerz commented Jul 11, 2023

For the record: the easiest way to review the rendered documentation locally is to run make servedocs in a checkout of this branch. Or, if you're on Windows or otherwise prefer not to use make, run julia --project=test and

julia> include("devrepl.jl")
julia> servedocs(port=8000, verbose=true)

Project.toml Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@fredrikekre
Copy link
Member

From #3, I think the only API thing that needs to be discussed is the return value of format_citation, if that is even considered public API. Right now it return either a string, or a vector of markdown segments. In #3 it is updated to be a MarkdownAST.Paragraph consistently, but this one is slightly more convoluted to construct as a user who just want to implement a custom style. Perhaps it can return a markdown string consistently and we parse and convert internally?

@goerz
Copy link
Member Author

goerz commented Jul 11, 2023

From #3, I think the only API thing that needs to be discussed is the return value of format_citation, if that is even considered public API.

At least post-1.0, I would prefer not to consider it (or anything detailed in Internals) part of the public API. And I agree, we can probably adapt to the next Documenter version without making any breaking changes.

Right now it return either a string, or a vector of markdown segments. In #3 it is updated to be a MarkdownAST.Paragraph consistently, but this one is slightly more convoluted to construct as a user who just want to implement a custom style. Perhaps it can return a markdown string consistently and we parse and convert internally?

Returning a markdown string that then gets parsed and inserted into the output tree is exactly the behavior I would like, see #6

@mortenpi mortenpi removed their request for review July 12, 2023 04:01
@mortenpi
Copy link
Member

I don't have any strong opinions here, and nothing stood out when I skimmed through the PR 🙂

The only suggestion I would have is to adopt the keep a changelog format for the changelog/NEWS.md. This would make it consistent with Documenter, and you could potentially benefit from some automated tooling in the future: https://github.com/JuliaDocs/Documenter.jl/blob/master/CHANGELOG.md

@goerz
Copy link
Member Author

goerz commented Jul 12, 2023

The only suggestion I would have is to adopt the keep a changelog format for the changelog/NEWS.md.

Sounds good to me! I've changed the format of NEWS.md accordingly.

Project.toml Outdated Show resolved Hide resolved
@fredrikekre fredrikekre merged commit 374a126 into master Jul 12, 2023
14 checks passed
@goerz goerz deleted the mg/update-documentation branch July 12, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants