Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate as, am, ac keywords for longer, more descriptive names #964

Closed
Datseris opened this issue Feb 3, 2024 · 1 comment · Fixed by #997
Closed

Deprecate as, am, ac keywords for longer, more descriptive names #964

Datseris opened this issue Feb 3, 2024 · 1 comment · Fixed by #997

Comments

@Datseris
Copy link
Member

Datseris commented Feb 3, 2024

I think we should deprecate the as, am, ac keywords of our main plotting function and call them instead agent_size, agent_color, agent_marker. Deprecation is easy for keyword arguments:

function f(; as = default, agent_size = as)
if as != default
@warn("as deprecated")
end
end

The rest of the keywords for the plotting function are not as cryptic.

@Datseris
Copy link
Member Author

Datseris commented Feb 3, 2024

This should be done after #934 I pressume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants