-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reset button in abmexploration #999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please describe the PR? What's the purpose of the offset time?
It helps to track the shifting amount for new data points appearing when plotting the agent/model data, otherwise the new points would cover the old ones in the plots |
in general it is a kwargs which shouldn't be used by users, maybe we can underscore it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong with git here. I see all commits of the PR #964 here as well.
Tested the branch at the latest commit locally, everything works, I think github is not working properly as usual, but let's see if everything works after merging |
Fixes #944