Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset button in abmexploration #999

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Fix reset button in abmexploration #999

merged 9 commits into from
Mar 7, 2024

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Mar 7, 2024

Fixes #944

@Tortar Tortar requested a review from Datseris March 7, 2024 03:04
@Tortar Tortar added this to the v6.0 milestone Mar 7, 2024
Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please describe the PR? What's the purpose of the offset time?

@Tortar
Copy link
Member Author

Tortar commented Mar 7, 2024

It helps to track the shifting amount for new data points appearing when plotting the agent/model data, otherwise the new points would cover the old ones in the plots

@Tortar
Copy link
Member Author

Tortar commented Mar 7, 2024

in general it is a kwargs which shouldn't be used by users, maybe we can underscore it

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with git here. I see all commits of the PR #964 here as well.

@Tortar
Copy link
Member Author

Tortar commented Mar 7, 2024

Tested the branch at the latest commit locally, everything works, I think github is not working properly as usual, but let's see if everything works after merging

@Datseris Datseris merged commit 6ea4453 into main Mar 7, 2024
3 of 6 checks passed
@Datseris Datseris deleted the f branch March 7, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix reset button working in abmexploration
2 participants