-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EventQueueABM
to multi-agent + make plotting and run model agnostic
#1001
Conversation
|
I think replicate! should be already good as it is, you just need to pass |
Released a new version of MixedStructTypes with the new function |
EventQueueABM
to multi-agentEventQueueABM
to multi-agent + make plotting model agnostic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great improvements!! I approve.
the test failure is no sense in the last commit, I just bumped the Agents.jl version trying to rerun now |
I try to merge if this resolves it, otherwise we make another PR |
This PR changes the
EventQueueABM
to use exclusively the@multiagent
macro and thekindof
shenanigans. That is because one cannot use multiple dispatch anyways inEventQueueABM
to decide the event, so there is no obvious benefit in usingUnion
type agents.The PR also re-organizes the codebase.
Additionally, this PR makes the plotting and data collection codes model agnostic. Detaches them entirely from the internals of the
AgentBasedModel
type that is passed into the plotting recipe.IT does the same for data collection and
run!
.TODOs: