Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a faster ordering for heap in EventQueueABM #1067

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Use a faster ordering for heap in EventQueueABM #1067

merged 3 commits into from
Aug 12, 2024

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Aug 12, 2024

Another 10% of time shaved with this, I think that's it for now :D

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me a comment is about the benchmarks. You are measuring everything in Rock Paper Scissors, right? We are confident that this model is representative for a generic speedup? I guess so...

@Tortar
Copy link
Member Author

Tortar commented Aug 12, 2024

yes, I'm measuring it. I'm confident enough on the generality but surely we could improve the benchmark by increasing the number of types

@Tortar Tortar merged commit e3a79f2 into main Aug 12, 2024
6 checks passed
@Tortar Tortar deleted the Tortar-patch-2 branch August 12, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants