Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Updates #886

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Docs Updates #886

merged 4 commits into from
Sep 22, 2023

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Sep 22, 2023

this fixes the Flocking example and improves the changelog for v6

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #886 (4eaf56e) into main (71fac47) will not change coverage.
The diff coverage is n/a.

❗ Current head 4eaf56e differs from pull request most recent head 9b09cdb. Consider uploading reports for the commit 9b09cdb to get more accurate results

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          42       42           
  Lines        2871     2871           
=======================================
  Hits         2088     2088           
  Misses        783      783           
Files Changed Coverage Δ
src/Agents.jl 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tortar
Copy link
Member Author

Tortar commented Sep 22, 2023

removed also the comparison table in the docs

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed also the comparison table in the docs

Please keep PRs focused, so it is easier to backtrack. I see many changes here that are really totally unrelated to the title of the PR!

The whole comparison page needs to be overhauled to contain as little information as possible, and point to the comparison repo as much as possible. But this needs to be done in a different PR!

@Tortar
Copy link
Member Author

Tortar commented Sep 22, 2023

ok, let's do it this way even if we weren't that formal always e.g. here https://github.com/JuliaDynamics/Agents.jl/pull/591/files, not to do too many PRs I will just create a different pr for the comparison page, since I think this is an important change so maybe being more focused on that can be useful, and for this one I will just enlarge the scope of the PR

@Tortar Tortar changed the title Fix flocking example Docs Updates Sep 22, 2023
Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, address comment and merge!

CHANGELOG.md Outdated Show resolved Hide resolved
@Tortar Tortar merged commit e1e58a7 into main Sep 22, 2023
5 checks passed
@Tortar Tortar deleted the fix-flock branch September 22, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants