-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Updates #886
Docs Updates #886
Conversation
Codecov Report
@@ Coverage Diff @@
## main #886 +/- ##
=======================================
Coverage 72.72% 72.72%
=======================================
Files 42 42
Lines 2871 2871
=======================================
Hits 2088 2088
Misses 783 783
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
removed also the comparison table in the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed also the comparison table in the docs
Please keep PRs focused, so it is easier to backtrack. I see many changes here that are really totally unrelated to the title of the PR!
The whole comparison page needs to be overhauled to contain as little information as possible, and point to the comparison repo as much as possible. But this needs to be done in a different PR!
ok, let's do it this way even if we weren't that formal always e.g. here https://github.com/JuliaDynamics/Agents.jl/pull/591/files, not to do too many PRs I will just create a different pr for the comparison page, since I think this is an important change so maybe being more focused on that can be useful, and for this one I will just enlarge the scope of the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, address comment and merge!
this fixes the Flocking example and improves the changelog for v6