Remove comparison table and just direct to comparison repository #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 72.72% 72.72%
=======================================
Files 42 42
Lines 2871 2871
=======================================
Hits 2088 2088
Misses 783 783 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Datseris
requested changes
Sep 24, 2023
Datseris
approved these changes
Sep 24, 2023
There was a problem hiding this comment.
I am approving this, but we probably need to revisit the "tabled based comparison" as well; Firstly, move it to comparison repo and secondly make it markdown based. But this can happen elsewhere.
(also, it is not clear to me how we would colorcode a markdown based table. Perhpas we could attach a unicode symbol to each cell denoting the "color")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably still too many details are mentioned here. Still the comparison repo doesn't have LOCs calculation, but will add them soon.