Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check in add_agent_pos! #903

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Remove unnecessary check in add_agent_pos! #903

merged 2 commits into from
Oct 7, 2023

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Oct 6, 2023

This will fail with an easy to bisect error anyway since adding to the model will fail since the agent type will not be accepted. Forgot to do it when merging #900

@Tortar Tortar requested a review from Datseris October 6, 2023 23:57
@Tortar
Copy link
Member Author

Tortar commented Oct 7, 2023

wops! sorry renamed one of the files before merging without changing the including statement!!

@Tortar
Copy link
Member Author

Tortar commented Oct 7, 2023

For some reason, I can't anymore bypass the protection rule otherwise I would have merged this one already

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Merging #903 (301d335) into main (fd62258) will increase coverage by 11.88%.
Report is 1 commits behind head on main.
The diff coverage is 88.50%.

@@             Coverage Diff             @@
##             main     #903       +/-   ##
===========================================
+ Coverage   80.21%   92.09%   +11.88%     
===========================================
  Files          44       33       -11     
  Lines        3028     2329      -699     
===========================================
- Hits         2429     2145      -284     
+ Misses        599      184      -415     
Files Coverage Δ
src/Agents.jl 100.00% <ø> (ø)
src/core/higher_order_iteration.jl 83.33% <ø> (ø)
src/core/model_single_container.jl 90.00% <100.00%> (ø)
src/core/space_interaction_API.jl 93.18% <100.00%> (+0.10%) ⬆️
src/simulations/collect.jl 96.56% <100.00%> (+0.02%) ⬆️
src/simulations/sample.jl 100.00% <100.00%> (ø)
src/spaces/continuous.jl 92.34% <100.00%> (+0.04%) ⬆️
src/spaces/discrete.jl 98.87% <100.00%> (ø)
src/spaces/graph.jl 76.19% <100.00%> (ø)
src/spaces/grid_multi.jl 83.33% <100.00%> (ø)
... and 12 more

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Datseris
Copy link
Member

Datseris commented Oct 7, 2023

@Tortar I've updated the rules of Agents.jl to ensure high quality of contributions.

  1. Can't push directly to master, must do PR.
  2. PRs must have one accepting review from someone other than the creator.

Things might get slower, but they are safer this way.

@Datseris Datseris merged commit bf6358d into main Oct 7, 2023
6 checks passed
@Datseris Datseris deleted the remove_check branch October 7, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants