Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify signatures #916

Merged
merged 14 commits into from
Nov 9, 2023
Merged

Simplify signatures #916

merged 14 commits into from
Nov 9, 2023

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Nov 7, 2023

Will do a pass of the library to simplify signatures for #915 . Still need to look at the most part of the library

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #916 (1bd9ecb) into main (668f1c0) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 90.90%.

❗ Current head 1bd9ecb differs from pull request most recent head f1398e1. Consider uploading reports for the commit f1398e1 to get more accurate results

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   80.77%   80.77%           
=======================================
  Files          45       45           
  Lines        2955     2955           
=======================================
  Hits         2387     2387           
  Misses        568      568           
Files Coverage Δ
src/core/model_single_container.jl 90.00% <100.00%> (ø)
src/core/space_interaction_API.jl 93.23% <100.00%> (ø)
src/spaces/continuous.jl 93.33% <100.00%> (ø)
src/spaces/utilities.jl 100.00% <100.00%> (ø)
src/submodules/io/csv_integration.jl 84.61% <ø> (ø)
src/submodules/pathfinding/astar.jl 90.12% <100.00%> (ø)
src/submodules/pathfinding/astar_continuous.jl 93.87% <ø> (ø)
src/submodules/pathfinding/astar_grid.jl 100.00% <ø> (ø)
src/spaces/discrete.jl 98.87% <50.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Tortar Tortar marked this pull request as draft November 7, 2023 10:19
@Tortar Tortar requested a review from Datseris November 7, 2023 11:00
@Tortar Tortar marked this pull request as ready for review November 7, 2023 11:01
@Tortar Tortar merged commit fa03585 into main Nov 9, 2023
5 checks passed
@Tortar Tortar deleted the simpler-signatures branch November 9, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants