Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abmtime for StandardABM #942

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Implement abmtime for StandardABM #942

merged 7 commits into from
Dec 14, 2023

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Dec 10, 2023

Fix #941

This just changes the behaviour of the step data collection which now uses the correct time of the model

@Tortar Tortar marked this pull request as draft December 10, 2023 14:24
@Tortar Tortar added this to the v6.0 milestone Dec 10, 2023
@Tortar Tortar marked this pull request as ready for review December 10, 2023 18:58
@Tortar Tortar requested a review from Datseris December 10, 2023 19:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3526b5c) 92.27% compared to head (a9d33c2) 92.18%.

Files Patch % Lines
src/simulations/collect.jl 90.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
- Coverage   92.27%   92.18%   -0.09%     
==========================================
  Files          33       33              
  Lines        2277     2291      +14     
==========================================
+ Hits         2101     2112      +11     
- Misses        176      179       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tortar
Copy link
Member Author

Tortar commented Dec 14, 2023

should be good to go @Datseris, and it would be good to merge this one before #940 because I slightly changed internals, so that we can acknowledge those changes in #940 before merging

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your effort, this looks great to me!

@Datseris Datseris merged commit c71a26a into main Dec 14, 2023
6 checks passed
@Datseris Datseris deleted the abmtime branch December 14, 2023 16:02
@Datseris
Copy link
Member

Ah, I now realize that we don't mention this function in AgentBasedModel which describes the accessor API to ABMs.

@Tortar
Copy link
Member Author

Tortar commented Dec 16, 2023

Also, I actually noticed too late that I slightly broke the abmexploration: when resetting the model, it returns to 0 step in data collection, which is correct, but doesn't play well with how data are plotted currently, will do a new PR fixing both of these issues eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create abmtime function for StandardABM
3 participants