Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with 4 processes (3 workers) #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Test with 4 processes (3 workers) #11

wants to merge 5 commits into from

Conversation

tkf
Copy link
Member

@tkf tkf commented Nov 24, 2021

This reverts commit 0fc7bf2.

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #11 (b30b77f) into master (0221d79) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   91.02%   90.90%   -0.12%     
==========================================
  Files           2        2              
  Lines          78       77       -1     
==========================================
- Hits           71       70       -1     
  Misses          7        7              
Flag Coverage Δ
Pkg.test 90.90% <ø> (-0.12%) ⬇️
Run.test 90.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/darray.jl 97.05% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0221d79...b30b77f. Read the comment docs.

@tkf
Copy link
Member Author

tkf commented Nov 24, 2021

@jpsamaroo Not sure if this is relevant to #10, but in #8 I found that the test hangs with Julia 1.8-DEV but not with Julia 1.6. https://github.com/JuliaFolds/FoldsDagger.jl/runs/4316965001?check_suite_focus=true

Also, in the current master branch (after #8), the entry point for the test will be a bit different (and should become a bit more robust for loading tests in multiple workers). I'm also trying to support the standard test entry point #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant