Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUSOLVER] Improve the dispatch for LAPACK routines #1806

Merged
merged 5 commits into from
Mar 16, 2023
Merged

[CUSOLVER] Improve the dispatch for LAPACK routines #1806

merged 5 commits into from
Mar 16, 2023

Conversation

amontoison
Copy link
Member

No description provided.

@maleadt
Copy link
Member

maleadt commented Mar 16, 2023

Is the chkuplo check not relevant? Base is still doing it in its LAPACK wrappers.

@amontoison
Copy link
Member Author

chkuplo is relevant but we need Julia 1.8 or higher to use it.

@maleadt
Copy link
Member

maleadt commented Mar 16, 2023

Wouldn't it be better to do a VERSION >= v"1.8" && chkuplo then, or isn't it worth it?

@amontoison
Copy link
Member Author

amontoison commented Mar 16, 2023 •
edited
Loading

I think it's better to do a VERSION >= v"1.8" && chkuplo(uplo).

@maleadt maleadt merged commit f3156e3 into JuliaGPU:master Mar 16, 2023
@amontoison amontoison deleted the cusolver_dense branch March 16, 2023 20:28
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
@amontoison @simonbyrne
[CUSOLVER] Improve the dispatch for LAPACK routines (JuliaGPU#1806)
f831d99
@maleadt maleadt mentioned this pull request Apr 1, 2024
Merged
@maleadt maleadt mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amontoison @maleadt